[auth] [janitor] Mop up some Lua records code

[miodvallat]

Short description

Today is a new moon, so it's perfect time to work on Lua support in PowerDNS.

This purely janitorial PR splits the monster function setupLuaRecords into pieces, so that every single Lua helper function (such as createReverse, ifurlup...) can be found in its own function.

This will help working in this area in the future.

Probably better reviewed in a per-commit basis, with whitespace changes ignored in the first commit.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[coveralls]

Pull Request Test Coverage Report for Build 13586761189

Details

• 0 of 559 (0.0%) changed or added relevant lines in 1 file are covered.
• 11505 unchanged lines in 206 files lost coverage.
• Overall coverage increased (+3.4%) to 64.465%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pdns/lua-record.cc	0	559	0.0%

Files with Coverage Reduction	New Missed Lines	%
ext/lmdb-safe/lmdb-typed.cc	1	89.66%
pdns/auth-catalogzone.hh	1	66.67%
pdns/dnsdistdist/dnsdist-kvs.hh	1	55.0%
pdns/dnsdistdist/dnsdist-lua-hooks.cc	1	94.59%
pdns/dnsdistdist/dnsdist-session-cache.cc	1	62.86%
pdns/dnswriter.hh	1	76.6%
pdns/dynlistener.hh	1	0.0%
pdns/inflighter.cc	1	90.48%
pdns/qtype.hh	1	86.96%
pdns/recursordist/nod.hh	1	92.59%

Totals
Change from base Build 13576694012:	3.4%
Covered Lines:	127628
Relevant Lines:	167023

---

💛 - Coveralls