Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional ID refactor: part 3 #843

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Optional ID refactor: part 3 #843

wants to merge 5 commits into from

Conversation

figueroa1395
Copy link
Contributor

@figueroa1395 figueroa1395 commented Nov 25, 2024

Follow-up PR after #828. Closes #806

Signed-off-by: Santiago Figueroa Manrique <[email protected]>
@figueroa1395 figueroa1395 added the improvement Improvement on internal implementation label Nov 25, 2024
@figueroa1395 figueroa1395 self-assigned this Nov 25, 2024
@figueroa1395 figueroa1395 changed the base branch from main to feature/optional-id-refactor-part2 November 25, 2024 11:48
This reverts commit 520c174.

Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Copy link

sonarcloud bot commented Nov 25, 2024

Base automatically changed from feature/optional-id-refactor-part2 to main November 25, 2024 12:30
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title Optional ID refactor - part 3 Optional ID refactor: part 3 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement on internal implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Refactor main model to move the optional id logic
1 participant