Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process hub cleanup and build updates #19

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Process hub cleanup and build updates #19

merged 7 commits into from
Nov 12, 2024

Conversation

anomit
Copy link
Member

@anomit anomit commented Nov 11, 2024

Fixes #

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.8.0 and above.
  • I ran pre-commit checks against my changes.
  • I've written tests against my changes and all the current present tests are passing.

Current behaviour

The process hub core used to control the spawning and restarting of worker processes -- for eg those responsible for snapshot and aggregate computes.

This was removed in the last merge to main. But there were a few helpers and features that were not cleaned up.

Also, the local collector runs as its own binary now instead of being run as a pm2 managed process and docker-compose.yaml needs to be udpated for the same.

New expected behaviour

As described above.

Change logs

Changed

  • Local collector docker container entry point

Removed

  • Process hub core helper

Deployment Instructions

  • To test in dev mode, use the source feature branch of this PR along with the dockerify branch of local collector.
  • For non-dev mode, use dockerify branch of both snapshotter-core and local collector.

@anomit anomit self-assigned this Nov 11, 2024
Copy link
Member

@xadahiya xadahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local and a staging server. LGTM! (after 9076960)

@anomit anomit merged commit 9d923fb into main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants