Skip to content

Commit

Permalink
new feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
anmenaga committed Oct 31, 2024
1 parent a590112 commit 7d5a4a0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
6 changes: 3 additions & 3 deletions build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ $filesForWindowsPackage = @(
'windows_baseline.dsc.yaml',
'windows_inventory.dsc.yaml'
'dsc_default.settings.json',
'settings.dsc.json'
'dsc.settings.json'
)

$filesForLinuxPackage = @(
Expand All @@ -66,7 +66,7 @@ $filesForLinuxPackage = @(
'RunCommandOnSet.dsc.resource.json',
'runcommandonset',
'dsc_default.settings.json',
'settings.dsc.json'
'dsc.settings.json'
)

$filesForMacPackage = @(
Expand All @@ -83,7 +83,7 @@ $filesForMacPackage = @(
'RunCommandOnSet.dsc.resource.json',
'runcommandonset',
'dsc_default.settings.json',
'settings.dsc.json'
'dsc.settings.json'
)

# the list of files other than the binaries which need to be executable
Expand Down
4 changes: 2 additions & 2 deletions dsc/src/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,9 @@ pub fn enable_tracing(trace_level_arg: &Option<TraceLevel>, trace_format_arg: &O
let mut tracing_setting = TracingSetting::default();

let default_filter = EnvFilter::try_from_default_env()
.or_else(|_| EnvFilter::try_new("error"))
.or_else(|_| EnvFilter::try_new("warning"))
.unwrap_or_default()
.add_directive(Level::ERROR.into());
.add_directive(Level::WARN.into());
let default_indicatif_layer = IndicatifLayer::new();
let default_layer = tracing_subscriber::fmt::Layer::default().with_writer(default_indicatif_layer.get_stderr_writer());
let default_fmt = default_layer
Expand Down
1 change: 1 addition & 0 deletions dsc_lib/src/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ pub fn parse_input_to_json(value: &str) -> Result<String, DscError> {

/// Will search setting files for the specified setting.
/// Performance implication: Use this function economically as every call opens/reads several config files.
/// TODO: cache the config
///
/// # Arguments
///
Expand Down

0 comments on commit 7d5a4a0

Please sign in to comment.