Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PSUseConsistantWhiteSpace when using statement is present #2091

Merged
merged 6 commits into from
Apr 4, 2025

Conversation

AlexandraDorey
Copy link
Contributor

@AlexandraDorey AlexandraDorey commented Apr 1, 2025

PR Summary

The addition of an using statement can cause the PSUseConsistant white space to fail due to how the InternalVisit of the UsingStatementAst is implemented in a slightly different way than other ASTs. See issue 2089 for more details.

PR Checklist

@AlexandraDorey
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey cool, good debugging. Read through your issue, I think you're right and this makes sense. Just approved the tests workflow.

@AlexandraDorey AlexandraDorey changed the title WIP - Fix for PSUseConsistantWhiteSpace when using statement is present Fix for PSUseConsistantWhiteSpace when using statement is present Apr 1, 2025
@AlexandraDorey AlexandraDorey reopened this Apr 2, 2025
Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, well done

@AlexandraDorey
Copy link
Contributor Author

AlexandraDorey commented Apr 3, 2025

Fixed the nits up, I'm not super familiar with github but I assume I can merge my commits into one commit when the PR merges or should I do that in by branch first? Otherwise should be good to merge once the tests run again :)

@andyleejordan andyleejordan enabled auto-merge (squash) April 4, 2025 00:51
@andyleejordan
Copy link
Member

Sure can!

@andyleejordan andyleejordan merged commit 2287a13 into PowerShell:main Apr 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants