-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for PSUseConsistantWhiteSpace when using statement is present #2091
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey cool, good debugging. Read through your issue, I think you're right and this makes sense. Just approved the tests workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, well done
Co-authored-by: Christoph Bergmeister <[email protected]>
Fixed the nits up, I'm not super familiar with github but I assume I can merge my commits into one commit when the PR merges or should I do that in by branch first? Otherwise should be good to merge once the tests run again :) |
Sure can! |
PR Summary
The addition of an using statement can cause the PSUseConsistant white space to fail due to how the InternalVisit of the UsingStatementAst is implemented in a slightly different way than other ASTs. See issue 2089 for more details.
PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.