Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ssh folder permissions check in SSHD #761

Merged
merged 15 commits into from
Jan 10, 2025
Merged

Update ssh folder permissions check in SSHD #761

merged 15 commits into from
Jan 10, 2025

Conversation

tgauth
Copy link
Collaborator

@tgauth tgauth commented Nov 11, 2024 •
edited
Loading

PR Summary

  • change sshd startup permissions check to log message to event viewer, rather than fail if expected permissions are not found
  • limit sshd startup permissions check to just ProgData\ssh folder, not ProgData\ssh\logs folder
  • add Pester Test for startup scenario
  • sample logging message:
image

PR Context

anmenaga
anmenaga suggested changes Dec 17, 2024
View reviewed changes
contrib/win32/win32compat/w32-sshfileperm.c Outdated Show resolved Hide resolved
regress/pesterTests/Setup.Tests.ps1 Outdated Show resolved Hide resolved
SteveL-MSFT
SteveL-MSFT requested changes Dec 20, 2024
View reviewed changes
contrib/win32/win32compat/w32-sshfileperm.c Outdated Show resolved Hide resolved
contrib/win32/win32compat/w32-sshfileperm.c Show resolved Hide resolved
contrib/win32/win32compat/w32-sshfileperm.c Outdated Show resolved Hide resolved
@tgauth
Copy link
Collaborator Author

tgauth commented Jan 6, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tgauth
Copy link
Collaborator Author

tgauth commented Jan 7, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SteveL-MSFT
SteveL-MSFT requested changes Jan 7, 2025
View reviewed changes
contrib/win32/win32compat/w32-sshfileperm.c Outdated Show resolved Hide resolved
contrib/win32/win32compat/w32-sshfileperm.c Show resolved Hide resolved
contrib/win32/win32compat/w32-sshfileperm.c Outdated Show resolved Hide resolved
contrib/win32/win32compat/w32-sshfileperm.c Outdated Show resolved Hide resolved
contrib/win32/win32compat/w32-sshfileperm.c Show resolved Hide resolved
@tgauth
Copy link
Collaborator Author

tgauth commented Jan 8, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tgauth
Copy link
Collaborator Author

tgauth commented Jan 9, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SteveL-MSFT
SteveL-MSFT requested changes Jan 9, 2025
View reviewed changes
contrib/win32/win32compat/w32-sshfileperm.c Outdated Show resolved Hide resolved
contrib/win32/win32compat/w32-sshfileperm.c Outdated Show resolved Hide resolved
@tgauth
Copy link
Collaborator Author

tgauth commented Jan 9, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tgauth tgauth merged commit b36bc85 into PowerShell:latestw_all Jan 10, 2025
4 checks passed
@tgauth tgauth deleted the update-perm-check branch January 10, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@anmenaga anmenaga anmenaga approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@vthiebaut10 vthiebaut10 Awaiting requested review from vthiebaut10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tgauth @SteveL-MSFT @anmenaga