Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loader Animation to Mars Rover Display Section during API call #129

Closed
wants to merge 13 commits into from

Conversation

DonaldReddy
Copy link
Contributor

Fixes #117

Loader.mp4

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

Additional context:

I've added loading animation to APoD and Rover Section.

Copy link

gitguardian bot commented May 13, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9250661 Triggered Generic High Entropy Secret 1b3f52f Pages/earthPics/script.js View secret
9250661 Triggered Generic High Entropy Secret ec0c4cc app.js View secret
9250661 Triggered Generic High Entropy Secret 8b0afb4 app.js View secret
9250661 Triggered Generic High Entropy Secret 8b0afb4 app.js View secret
9250661 Triggered Generic High Entropy Secret 0fd9b8c Pages/asteroid-info/script.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@DonaldReddy
Copy link
Contributor Author

Hey @PranavBarthwal should we wait till project migration happens?

Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR has merge conflicts please resolve them

@DonaldReddy
Copy link
Contributor Author

DonaldReddy commented May 16, 2024

@PranavBarthwal some previous merges have changed the UI and navbar links to other pages,
Someone has opened the pull request without syncing with the latest merge. please look into it.

@DonaldReddy
Copy link
Contributor Author

@surajvast1 some previous merges have changed the UI and navbar links to other pages,
Someone has opened the pull request without syncing with the latest merge. please look into it.

@surajvast1
Copy link
Collaborator

The project is currently in very initial stage and some important issues are yet to be completed. Lets keep this on hold currently.
We will get back to you ||

@DonaldReddy DonaldReddy closed this Jun 5, 2024
@DonaldReddy DonaldReddy deleted the api-loader branch June 5, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Loader Animation to Mars Rover Display Section during API call
3 participants