Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Redesign Mars rover imagery page #358

Merged
merged 19 commits into from
Jun 8, 2024

Conversation

DonaldReddy
Copy link
Contributor

Redesign Mars rover imagery page

Issue number

closes: #343

Video/Screenshots (mandatory)

Untitled.video.-.Made.with.Clipchamp.mp4

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

Additional context:

Copy link

vercel bot commented Jun 5, 2024

@DonaldReddy is attempting to deploy a commit to the pranavbarthwal's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Jun 5, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, you can contact the mentors for this project.

@DonaldReddy
Copy link
Contributor Author

@PranavBarthwal Please review this PR.

@DonaldReddy
Copy link
Contributor Author

@PranavBarthwal review this PR.

Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts
and also fix the padding and spacing between cards and images
image

@DonaldReddy
Copy link
Contributor Author

DonaldReddy commented Jun 7, 2024

@PranavBarthwal I've added padding,please review this PR.
image

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmo-xplore ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 6:32pm

Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployment is giving error

image

@DonaldReddy
Copy link
Contributor Author

@PranavBarthwal try now.

Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still giving error

image

@DonaldReddy
Copy link
Contributor Author

@PranavBarthwal i tried deploying this branch on vercel, and everything was fine.
https://cosmo-xplore-phi.vercel.app/

@PranavBarthwal PranavBarthwal merged commit f990571 into PranavBarthwal:main Jun 8, 2024
3 checks passed
@surajvast1
Copy link
Collaborator

@DonaldReddy Good job here .But could you align the image and text in some other format. Like image to left and text to right .It looks fine in the mobile view .
You can create a new issue for this

@surajvast1
Copy link
Collaborator

And also add links and a button for people ho wants to read more about the specific rovers .

@DonaldReddy
Copy link
Contributor Author

DonaldReddy commented Jun 9, 2024

Sure @surajvast1, I'll work on that. But the format you mentioned won't fit in mobile view, so I'll make it for bigger screen.

@DonaldReddy DonaldReddy deleted the update-mars-page branch June 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign Mars rover imagery page
3 participants