-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: Redesign Mars rover imagery page #358
[Feat]: Redesign Mars rover imagery page #358
Conversation
@DonaldReddy is attempting to deploy a commit to the pranavbarthwal's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, you can contact the mentors for this project. |
@PranavBarthwal Please review this PR. |
@PranavBarthwal review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PranavBarthwal I've added padding,please review this PR. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PranavBarthwal try now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PranavBarthwal i tried deploying this branch on vercel, and everything was fine. |
@DonaldReddy Good job here .But could you align the image and text in some other format. Like image to left and text to right .It looks fine in the mobile view . |
And also add links and a button for people ho wants to read more about the specific rovers . |
Sure @surajvast1, I'll work on that. But the format you mentioned won't fit in mobile view, so I'll make it for bigger screen. |
Redesign Mars rover imagery page
Issue number
closes: #343
Video/Screenshots (mandatory)
Untitled.video.-.Made.with.Clipchamp.mp4
Checklist:
contributing.md
file before contributingAdditional context: