Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Overlapping of Chatbot and Scroll to Top Button #384

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

aslams2020
Copy link
Contributor

Hi @PranavBarthwal, @surajvast1 & @harshit-sharmaaa,
closes #380

considering the current positioning where the chatbot is in the rightmost bottom of the page and the scroll-to-top button is just above it, I adjusted the scroll-to-top button to be moved to the left side of the page to avoid overlap.

Video/Screenshots (mandatory)

Here as you can see :

image

Please take a look.

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

Copy link

vercel bot commented Jun 9, 2024

@aslams2020 is attempting to deploy a commit to the pranavbarthwal's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Jun 9, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, you can contact the mentors for this project.

@aslams2020
Copy link
Contributor Author

@PranavBarthwal Could you please tell me why did you revert the "merged" PR.
If there's anything to improve in the solution feel free to tell me.

@surajvast1
Copy link
Collaborator

Suggestion : I believe a simple implementation of this could be adding the chatbot button above the scroll button .

@aslams2020
Copy link
Contributor Author

@surajvast1, I thought of it in the first place but you gave the instructions not to do anything with the chatbox, because other contributors were working on it already and to avoid conflicts too.

if you say, i can make the allignment as below :

image

Please tell me which one should i do.
i'll be happy to make the necessary changes to the issue.
Thankyou for understanding.

@surajvast1
Copy link
Collaborator

surajvast1 commented Jun 10, 2024

If you go through my instructions clearly i said not to change anything in the boundary of the chatbox. I also mentiond the pull requests for you to analyse them.

image

Also You could have made things clear by asking,Anyways @PranavBarthwal will tell you about it from now on.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG 🐞: "Scroll to Top" Button and "Chat-Bot" are Overlapping
3 participants