Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add animation to text and images #394

Closed
wants to merge 8 commits into from
Closed

Conversation

Skb08
Copy link

@Skb08 Skb08 commented Jun 10, 2024

Add Animation in Cards and Text on Scroll

Issue number

closes: #385

Video/Screenshots (mandatory)

2024-06-10-17-02-54.mp4

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

Additional context:

Due to network issues, my video is lagging a bit.

Copy link

vercel bot commented Jun 10, 2024

@Skb08 is attempting to deploy a commit to the pranavbarthwal's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, you can contact the mentors for this project.

@surajvast1
Copy link
Collaborator

surajvast1 commented Jun 10, 2024

@Skb08 The video is lagging a lot .Upload a video with proper smoothness .Also there is a latency in the text and images reduce that

@Skb08
Copy link
Author

Skb08 commented Jun 12, 2024

2024-06-11-23-16-51.mp4

Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use more shorter & smoother transitions, and make sure text and images appear at the same time.

@surajvast1
Copy link
Collaborator

Also mars imagery page transitions would be irrelevant because we are changing it completely

@Skb08 Skb08 closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Animation in Cards and Text on Scroll
3 participants