fix metadata storage path for RayTaskRunner
#16022
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
force-pushed
the
fix-ray-results
branch
from
0da538f
to
dece978
Compare
CodSpeed Performance ReportMerging #16022 will not alter performanceComparing Summary
|
zzstoatzz
force-pushed
the
fix-ray-results
branch
4 times, most recently
from
ecec785
to
7a41130
Compare
revert unintentional log removal yuhhhhhhhh
just install in the action whoops
zzstoatzz
force-pushed
the
fix-ray-results
branch
from
6589666
to
4eb7b5c
Compare
desertaxle
requested changes
Nov 15, 2024
| if ( | ||
| self.result_storage is None | ||
| and update.get("result_storage") is None | ||
| or (self.result_storage and self.result_storage.basepath is None) |
There was a problem hiding this comment.
I think this change may have unintended consequences since it will now ignore all result storage that doesn't have a basepath, which is valid in cases like storing at the root of an S3 bucket.
I think we may need to dig deeper to find the root cause of this issue and why the block configuration isn't coming through correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16009
as described in the linked issue, we were writing result metadata files to the
cwdwhen using a ray task runner because child processes would get aNonestoragebasepath- this PR checks for this case and makes sure we also respect theresult_storage_key