make re-usable TypeAdapter instances for client schemas
#16089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #16089 will not alter performanceComparing Summary
|
this does makes sense, since we're making all of the adapters at import time, but I think this is worth it |
zzstoatzz
changed the title
TypeAdapter instances for client schemas
zzstoatzz
force-pushed
the
make-less-adapters
branch
2 times, most recently
from
7654e26 to
c2420ee
Compare
zzstoatzz
added
the
development
zzstoatzz
force-pushed
the
make-less-adapters
branch
from
c2420ee to
36ed5ac
Compare
zzstoatzz
added
the
performance
zzstoatzz
force-pushed
the
make-less-adapters
branch
2 times, most recently
from
3e06bdb to
db7bfe8
Compare
desertaxle
approved these changes
Dec 13, 2024
Comment on lines
+178
to
+181
| BaseResult.model_rebuild() | ||
| ResultRecordMetadata.model_rebuild() | ||
|
|
||
| State.model_rebuild() |
There was a problem hiding this comment.
We do this in prefect.main too. Do we need to rebuild again here? Or is there a way that we could conditionally rebuild?
There was a problem hiding this comment.
if I don't then I get errors like this
FAILED tests/client/test_prefect_client.py::test_set_then_read_flow_run_state - pydantic.errors.PydanticUndefinedAnnotation: name 'State' is not definedthough I agree it seems like it shouldn't be needed 🤔
There was a problem hiding this comment.
ill make a discussion to investigate this
zzstoatzz
force-pushed
the
make-less-adapters
branch
from
db7bfe8 to
b442d2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves creation of type adapters out of client method impls
related to #15047
uses
defer_buildas pointed out by adam below