Teams initial support #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triedandtested-dev
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
triedandtested-dev
force-pushed
the
feature/teams-access-support
branch
from
dc8b1cf to
e2dc919
Compare
|
@gabcoyne I removed the unsupported checker from the linter should be good now |
|
Nice!👌 This would help out us quite a bit also! |
parkedwards
reviewed
Mar 20, 2024
| @@ -155,7 +155,6 @@ linters-settings: | |||
| - sliceClear | |||
| - sloppyLen | |||
| - sloppyReassign | |||
| - sloppyTestFuncName | |||
parkedwards
reviewed
Mar 20, 2024
| # Assign the Workspace Role to the Team | ||
| resource "prefect_workspace_access" "team_developer" { | ||
| accessor_type = "TEAM" | ||
| accessor_id = "11111111-1111-1111-1111-111111111111" |
There was a problem hiding this comment.
Suggested change
| accessor_id = "11111111-1111-1111-1111-111111111111" | |
| accessor_id = prefect_account_member.marvin.user_id |
just to reinforce that accessor_id is either a service account ID or an account member ID (eg a user). "accessor" is kind of an abstract term we chose here to unify the bot/user domains, so it might not be immediately clear to the TF user
parkedwards
reviewed
Mar 20, 2024
| // TeamFilter defines the search filter payload | ||
| // when searching for team by name. | ||
| // example request payload: | ||
| // {"teams": {"name": {"any_": ["test"]}}}. |
parkedwards
reviewed
Mar 20, 2024
| @@ -87,9 +87,9 @@ func (r *WorkspaceAccessResource) Schema(_ context.Context, _ resource.SchemaReq | |||
| }, | |||
| "accessor_type": schema.StringAttribute{ | |||
| Required: true, | |||
| Description: "USER or SERVICE_ACCOUNT", | |||
| Description: "USER | SERVICE_ACCOUNT | TEAM", | |||
parkedwards
approved these changes
Mar 20, 2024
triedandtested-dev
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
triedandtested-dev
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
|
taking a look at the failing CI steps |
|
ok this has to do with how we set up our workflow triggers - GHA won't insert Secrets from a forked workflow for obvious reasons. I'm going to merge this in, but also sanitize our main branch in case there are failures. thanks for the contribution @triedandtested-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #144