-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker Compose file for local testing #187
Conversation
Adds a local Docker Compose file to start an instance of Prefect that we can reach with `terraform` commands. Closes #186
62f370f
to
077c34b
Compare
- Adds example Terraform configuration to provision a work pool - Adds contribution docs on how to use it.
077c34b
to
502047c
Compare
Helps group related information for easier navigation.
@parkedwards - looking at the PREFECT_API_URL in the acceptance tests CI file, I suspect we could replace the value (which I think points to dev or staging) and instead spin up a Prefect server instance using this new Docker Compose setup. That'd give us fresh environments to test against in CI and might help with transient errors related to environment pollution. Does that sound right/fair? If so I'll open an issue and we can look into it more in a separate PR. |
@mitchnielsen that sounds right - could be something like just a caveat - one wrinkle is that our OSS server isn't an exact match/port of our SaaS (which the current acceptance tests are mostly oriented towards supporting) - the OSS server has a subset of features and endpoints. so there may be some extra potholes we hit as we try to marry the tests<>this local prefect server instance. but i like where this is going |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea
Great point. I added this note in #192. |
Summary
Adds a local Docker Compose file to start an instance of Prefect that we can reach with
terraform
commands.Closes #186
Testing
Click to expand