fix(client): ensure urls have trailing slashes #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some API routes need to have a trailing slash on the end. If they don't, you can see errors such as 404, 405, 307, etc. Closes https://linear.app/prefect/issue/PLA-948/workspace-create-fails-with-404-when-endpoint-is-set Closes #359
Adds a script to help check which routes have trailing slashes.
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
…t into trailing-slashes
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
Comment on lines
+32
to
+36
| curl -s https://api.prefect.cloud/api/openapi.json | | ||
| jq '.paths | ||
| | to_entries | ||
| | map({path: .key, method: (.value | to_entries[0].key), desc: (.value | to_entries[0].value.description)}) | ||
| | map(select(.path | test("/$")))' |
There was a problem hiding this comment.
this is great! Is there anywhere in our development guides that we should add a note/reference to this to point community contributors to?
There was a problem hiding this comment.
good idea, I'll add a note in the Contributing guide 👌
There was a problem hiding this comment.
done in 38edad2
jamiezieziula
approved these changes
Jan 31, 2025
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some API routes need to have a trailing slash on the end. If they don't,
you can see errors such as 404, 405, 307, etc.
Closes https://linear.app/prefect/issue/PLA-948/workspace-create-fails-with-404-when-endpoint-is-set
Closes #359