feat(accounts): support account domains #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better follows the pattern of the other APIs, and this was an unnecessary extra struct.
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
These fields are not currently implemented, and most users probably won't want or need to reference them. They're also read-only.
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
force-pushed
the
further-account-support
branch
from
c286d48 to
54fd6d0
Compare
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
This reverts commit 54fd6d0. No need to expose this field.
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
mitchnielsen
changed the title
…t into further-account-support
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
jamiezieziula
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to https://linear.app/prefect/issue/PLA-354/add-support-for-accounts
Implements the account domains API to finish up the remaining fields we should expose on the Accounts resource and datasource. This is related to configuring SSO.
There are many other fields, but most of them are only relevant to Prefect-internal teams. We can focus on exposing the main fields from the UI as well as a couple others like domains and settings that may be helpful: