Use shouldRenderComponent to reduce rendering and recalculation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By creating a component that only takes relevant properties that would cause a recalculation, we're free to redefine shouldRenderComponent to compare object equality of all of the props. If any props change, render (and recalculate); otherwise, no need to render or recalculate. This is similar to memoization, but using `react` lifecycle. In order for this approach to work, you have to create a component that _doesn't_ take an unrelated prop (i.e. `currentTheme`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating a component that only takes relevant properties that would
cause a recalculation, we're free to redefine shouldRenderComponent to
compare object equality of all of the props. If any props change, render
(and recalculate); otherwise, no need to render or recalculate. This
is similar to memoization, but using
reactlifecycle.In order for this approach to work, you have to create a component that
doesn't take an unrelated prop (i.e.
currentTheme).