Memoize prop transformation functions and specify their arguments #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to be similar to reselect's
createSelector
, but instead ofreaching into redux
state
, it reaches into the component'sthis
.@jgautsch I tried to make
reselect
work inside the component, butreselect
expects inputSelectors, which are functions that map state to inputs, and then pass those inputs to the transformation function.Instead, we need to be able to map things already inside the component (such as
this.props.something
orthis.someOtherDerivedData
) into inputs that are passed to the transformation function.There might be a way to clean up the API a little, but for now, it's pretty similar to
reselect
.