-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NCF_PyTorch models #536
Conversation
I did a quick exp with
and get these results:
The results for the same dataset from implemented Tensorflow version, same embedding/structure size (which are acquired from
Those results are with some random hyperparameters without carefully tuning, so I think PyTorch version is comparable with Tensorflow version. @darrylong please help review the code! Thanks. |
@hieuddo any idea why GMF performance is quite low as compared to others? |
Turned out to be because of
This could be due to overfitting because Anyway, my point still stands: comparable exp results are achievable with this PyTorch implementation. One discussion though, should we stick to the original paper and hard-coded |
@hieuddo I refactor the code so we can specify |
|
For now, it seems fine to me. Will check again later because I'll be using NCF-PyTorch in the future.
No specific reason. Just my random wonder. So let's just stick with Btw, your "refactor" commit is wonderful madness. I guess I'll be contributing more to |
Here are results running the example with the two backend:
They look comparable both in terms of performance and time. Still missing model @hieuddo @darrylong feel free to merge if you're comfortable with this. Thanks Hieu again for the contribution. |
Add PyTorch backend for NCF models --------- Co-authored-by: tqtg <[email protected]>
Description
Add the option to use NCF models in PyTorch (implemented models are tensorflow).
Checklist: