Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean compiled cpp files #539

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Clean compiled cpp files #539

merged 3 commits into from
Oct 25, 2023

Conversation

tqtg
Copy link
Member

@tqtg tqtg commented Oct 25, 2023

Description

CPP files should be compiled from source PYX files depending on building environment for better compatibility. This also help clean up the repo and reduce codebase significantly.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

Copy link
Member

@lthoang lthoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqtg tqtg merged commit 850c5c7 into PreferredAI:master Oct 25, 2023
12 checks passed
@tqtg tqtg deleted the clean-cpp-files branch October 25, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants