-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyTorch backend for MF #546
Conversation
Results obtained from
|
cornac/models/mf/torchmf.py
Outdated
|
||
def forward(self, uids, iids): | ||
ues = self.u_factors(uids) | ||
uis = self.i_factors(iids) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean ies
(item embeddings) here?
@hieuddo I did some code refactoring to merge them into one MF model with different options of backends. The results appear to be similar to yours.
|
Looks great. One minor, though: should we unify formatter settings to reduce changes due to different formatters? I'm currently using |
@hieuddo I'm also using |
Description
examples/biased_mf.py
user_idx
oritem_idx
is unknown?cornac/cornac/models/mf/recom_mf.pyx
Line 269 in b44e19c
Checklist: