Add meta framework into theme #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matks
commented
Jul 8, 2024
matks
commented
| Questions | Answers |
|---|---|
| Description? | Add meta framework into theme to allow module developers to find out what framework is used |
| Type? | new feature |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes partially PrestaShop/hummingbird#581 |
| Sponsor company | |
| How to test? | See PrestaShop/hummingbird#581 |
boherm
approved these changes
Jul 9, 2024
|
Hello @matks , Is there a how to test for QA ? or can this be tested by a dev ? |
matks
commented
Aug 19, 2024
| @@ -10,6 +10,7 @@ meta: | |||
| compatibility: | |||
| from: 9.0.0 | |||
| to: ~ | |||
| framework: 'bootstrap-v4.0.0-alpha.5' | |||
There was a problem hiding this comment.
Discussion with @jolelievre: what should be the content of
- 'bootstrap-v4.0.0-alpha.5'
- 'v4'
- 'bootstrap-v4.0.0'
- ...
There was a problem hiding this comment.
bootstrap-v4.0.0-alpha.5bootstrap-v5.3.3tailwind-v3.4.10
|
I guess that means it's a GO 😉 |
|
Merging as it's just 1 line in a config file |
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.