-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for node iron lts #155
Changes from 6 commits
436d8a5
e4ff6db
f1aa9b4
57c64e0
4d35f46
c660d7c
f18652b
cbcd0b0
9150d1a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"extends": [ | ||
"development" | ||
], | ||
"hints": { | ||
"compat-api/css": [ | ||
"default", | ||
{ | ||
"ignore": [ | ||
"-moz-appearance" | ||
] | ||
} | ||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
nodes_modules |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,8 +150,6 @@ | |
width: auto; | ||
|
||
.btn { | ||
padding: 0.5rem 0.6875rem; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why remove this one? This seems like an UX change not required for the Node 20 compatibility no? |
||
|
||
i { | ||
top: 0.125rem; | ||
left: 0.1875rem; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -233,10 +233,11 @@ textarea { | |
$gray-light | ||
url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAQAAAD9CzEMAAAAPklEQVR4Ae3TwREAEBQD0V/6do4SXPZg7EsBhsQ8IEmSMOsiuEfg3gL3oXC7wK0bd1G4o8X9F4yIkyQfSrIByQBjp7QuND8AAAAASUVORK5CYII=") | ||
no-repeat scroll right 0.5rem center / 1.25rem 1.25rem; | ||
/* stylelint-disable */ | ||
/* stylelint-disable-next-line property-no-vendor-prefix */ | ||
-moz-appearance: none; | ||
/* stylelint-disable-next-line property-no-vendor-prefix */ | ||
-webkit-appearance: none; | ||
/* stylelint-enable */ | ||
appearance: none; | ||
} | ||
|
||
.form-control-valign { | ||
|
@@ -599,7 +600,6 @@ form { | |
.modal-dialog-centered { | ||
display: flex; | ||
align-items: center; | ||
// 30px corresponds to the default margin size from bootstrap 4.0.0-alpha.5 for modal-dialog class | ||
min-height: calc(100% - (30px * 2)); | ||
} | ||
|
||
|
@@ -608,17 +608,22 @@ form { | |
} | ||
|
||
input[type="number"] { | ||
/* stylelint-disable */ | ||
/* stylelint-disable-next-line property-no-vendor-prefix */ | ||
-moz-appearance: textfield; | ||
appearance: textfield; | ||
|
||
&::-webkit-outer-spin-button, | ||
&::-webkit-inner-spin-button { | ||
margin: 0; | ||
/* stylelint-disable-next-line property-no-vendor-prefix */ | ||
-webkit-appearance: none; | ||
} | ||
/* stylelint-enable */ | ||
} | ||
|
||
.ui-autocomplete.ui-front { | ||
z-index: 999; | ||
} | ||
|
||
.btn.btn-touchspin.js-touchspin.bootstrap-touchspin-up { | ||
border-radius: 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question as above, what is the link between this and the Node 20 compatibility? |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,8 +72,8 @@ function createSpin() { | |
$.each($(spinnerSelector), (index, spinner) => { | ||
$(spinner).TouchSpin({ | ||
verticalbuttons: true, | ||
verticalupclass: 'material-icons touchspin-up', | ||
verticaldownclass: 'material-icons touchspin-down', | ||
verticalupclass: 'glyphicon glyphicon-plus', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't this change the style of all the icons? |
||
verticaldownclass: 'glyphicon glyphicon-minus', | ||
buttondown_class: 'btn btn-touchspin js-touchspin js-increase-product-quantity', | ||
buttonup_class: 'btn btn-touchspin js-touchspin js-decrease-product-quantity', | ||
min: parseInt($(spinner).attr('min'), 10), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be put in the
_dev
folder along with thepackage.json
file and all the other configs?