-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8.4 #406
Add PHP 8.4 #406
Conversation
Hlavtox
commented
Nov 19, 2024
Questions | Answers |
---|---|
Description? | Add PHP 8.4 |
Type? | |
BC breaks? | |
Deprecations? | |
Fixed ticket? | |
Sponsor company | |
How to test? |
Not out scope. Ping @PrestaShop/tech-council |
Maybe we could simplify installation a bit with https://github.com/mlocati/docker-php-extension-installer ADD --chmod=0755 https://github.com/mlocati/docker-php-extension-installer/releases/latest/download/install-php-extensions /usr/local/bin/
RUN install-php-extensions gd imagick bcmath intl pdo_mysql mysqli zip memcached xdebug Although |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for this but I block for now, we first need to test the core compatibility with PHP 8.4 before we release new dockers
@jolelievre Can we merge? :-) |
This PR only adds the new version but it doesn't generate the docker images so it won't create any new dockers Besides @Progi1984 is working on those in this PR #410 so that we rely on nightly builds now, so maybe the new version should also be added in his PR instead |
Handled in #410 |