Skip to content

Commit

Permalink
Review feedbacks
Browse files Browse the repository at this point in the history
  • Loading branch information
NeOMakinG committed Jan 2, 2023
1 parent 625f20b commit 781a1a9
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 13 deletions.
3 changes: 1 addition & 2 deletions src/scss/core/components/_search.scss
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ $component-name: search;

&__results {
max-height: 20rem;
padding: 0.5rem;
padding-right: 1.5rem;
padding: 0.5rem 1.5rem 0.5rem 0.5rem;
margin: 0;
overflow-y: scroll;
}
Expand Down
2 changes: 1 addition & 1 deletion src/scss/core/layout/_header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ $component-name: header;
max-width: 100vw;
background-color: var(--header-bg);

a:not(.dropdown-item) {
a:not(.dropdown-item):not(.btn) {
color: var(--header-color);

&:hover {
Expand Down
14 changes: 7 additions & 7 deletions templates/_partials/form-fields.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<div class="mb-3{if !empty($field.errors)} has-error{/if}">
{if ($field.type !== 'checkbox')}
<label class="form-label{if $field.required} required{/if}" for="{$field.name}">
<label class="form-label{if $field.required} required{/if}" for="field-{$field.name}">
{if $field.type !== 'checkbox'}
{$field.label}
{/if}
Expand Down Expand Up @@ -55,12 +55,12 @@
class="form-check-input"
type="radio"
name="{$field.name}"
id="{$field.name}_{$value}"
id="field-{$field.name}_{$value}"
value="{$value}"
{if $field.required}required{/if}
{if $value eq $field.value} checked {/if}
>
<label class="form-check-label" for="{$field.name}_{$value}">
<label class="form-check-label" for="field-{$field.name}_{$value}">
{$label}
</label>
</div>
Expand All @@ -77,11 +77,11 @@
name="{$field.name}"
type="checkbox"
value="1"
id="{$field.name}"
id="field-{$field.name}"
value="1" {if $field.value}checked="checked"{/if}
{if $field.required}required{/if}
>
<label class="form-check-label" for="{$field.name}">
<label class="form-check-label" for="field-{$field.name}">
{$field.label nofilter}
</label>
</div>
Expand Down Expand Up @@ -128,7 +128,7 @@
<input
class="form-control js-child-focus js-visible-password"
name="{$field.name}"
id="{$field.name}"
id="field-{$field.name}"
type="password"
{if $field.autocomplete}autocomplete="{$field.autocomplete}"{/if}
value=""
Expand Down Expand Up @@ -159,7 +159,7 @@
<input
class="form-control"
name="{$field.name}"
id="{$field.name}"
id="field-{$field.name}"
type="{$field.type}"
value="{$field.value}"
{if $field.autocomplete}autocomplete="{$field.autocomplete}"{/if}
Expand Down
4 changes: 1 addition & 3 deletions templates/customer/_partials/order-messages.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
<p class="fw-bold mb-0">{$message.name}</p>
<p class="fs-6 mb-0">{$message.message_date}</p>
</div>
<div class="col-sm-8">
{$message.message nofilter}
</div>
<div class="col-sm-8">{$message.message nofilter}</div>
</div>
</div>
{/foreach}
Expand Down

0 comments on commit 781a1a9

Please sign in to comment.