-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix QA feedbacks #414
Fix QA feedbacks #414
Conversation
NeOMakinG
commented
Dec 21, 2022
Questions | Answers |
---|---|
Description? | The QA did some feedbacks that we need to tackle |
Type? | bug fix |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | Fixes #409 . |
How to test? | See QA feedbacks list of the issue and test it |
Possible impacts? | Global |
Do we need XHTML compatibility? |
Well it was to check for a browser validation bug but we can just kick them out |
We could use a smarty linter/fixer to enforce consistency through all themes and modules: remove useless |
Yeah, I did try to find one years ago but unfortunately, it doesn't seem to exist at all 😢 |
@@ -45,7 +45,7 @@ | |||
{/block} | |||
|
|||
{block name='cart_voucher_notifications'} | |||
<div class="alert alert-danger js-error d-none" role="alert"> | |||
<div class="alert alert-danger js-error mt-2" role="alert" style="display: none;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline style? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kpodemski this is a core limitation from the core.js
file toggling this error when the voucher trigger it