Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data-refresh-url in address-form.tpl #442

Closed
wants to merge 1 commit into from
Closed

Update data-refresh-url in address-form.tpl #442

wants to merge 1 commit into from

Conversation

sudo-do
Copy link
Contributor

@sudo-do sudo-do commented Jan 27, 2023

Questions Answers
Description? Please be specific when describing this change. What did you change? Why?
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #441
Sponsor company
How to test?

@sudo-do
Copy link
Contributor Author

sudo-do commented Jan 27, 2023

It works in order page but still not works in account > add new address

@Hlavtox
Copy link
Contributor

Hlavtox commented Jan 27, 2023

The TPL should not be the case, it's the same on classic - https://github.com/PrestaShop/classic-theme/blob/develop/templates/checkout/_partials/address-form.tpl

@sudo-do
Copy link
Contributor Author

sudo-do commented Jan 27, 2023

I understand, Something is wrong about how the form response handled, I compared the response of add new adress form and on classic theme it returns 302, but while hummingbird is running response 200 and content is the error page we see...
image

@sudo-do
Copy link
Contributor Author

sudo-do commented Jan 27, 2023

@Hlavtox I found where the issue is! I deleted assets/js and it works now. What do you think about this?
I'm not sure i can do anything about this I don't know javascipt.
image

@sudo-do
Copy link
Contributor Author

sudo-do commented Jan 27, 2023

latest working release is v0.1.1

@sudo-do sudo-do closed this Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't add new adress with hummingbird theme
2 participants
@sudo-do @Hlavtox