Modified Add-to-card form and token function on homepage #443
Conversation
sudo-do
commented
Jan 28, 2023
sudo-do
commented
| Questions | Answers |
|---|---|
| Description? | An ID has been added to the 'add-to-card' form on the homepage and the function that provides tokens in the 'product.ts' file has been modified to only affect forms with that specific ID. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #441 |
| Sponsor company | |
| How to test? | The ability to add items to a card on the homepage, the capability to include a new address during the checkout process, and the capability to add a new address in the 'My Account' page should be present and function correctly without any errors. |
|
The relevant functions are functioning correctly without any issues. |
|
We can't use ID here as this button will appear many times on products list. Check the comment above your change. It states this has to be fixed inside core.js so please try fixing it on the main Prestashop repo. |
|
I didn't know id must be unique thanks. |
id attribute must identify a single html element on the page. Only classes can be repeated multiple times. |
|
Also, make sure to name it correctly: Misspelling this is a recipe for compatability issues where some think it's cart and some card, and the other way around if it is "corrected" in the future. |
