Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple slider update on facetsearch #550

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

tblivet
Copy link
Contributor

@tblivet tblivet commented Sep 28, 2023

Questions Answers
Description? Fix an issue when multiple sliders are presents on faceted search ( the price and product weight who show in slider mode )
Type? bug fix
BC breaks? no
Deprecations?
Fixed ticket? This fix is related to this previous fix 81e8204
Sponsor company @PrestaShopCorp
How to test? You have to add some weight on few products for example one with 1kg another with 2kg and another with 3kg after that you can go to ps_facetedsearch configuration module click on "Reconstruire l'index intégralement" after that you can access in FO the category that contains the products with different weights and check if the price and weight filter work well :)

Copy link
Contributor

@mflasquin mflasquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@boherm boherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too, thanks @tblivet!

@florine2623 florine2623 self-assigned this Oct 2, 2023
@florine2623
Copy link

Hello @tblivet ,

When I install the PR, I can't choose "Use this theme" option. I'm having this issue :
Screenshot 2023-10-02 at 16 21 34

@tblivet
Copy link
Contributor Author

tblivet commented Oct 9, 2023

Hello @tblivet ,

When I install the PR, I can't choose "Use this theme" option. I'm having this issue : Screenshot 2023-10-02 at 16 21 34

Hello @florine2623,
I don't know how you are testing the theme, but I think you have to compile the theme before testing it with the npm run build command.

@florine2623
Copy link

Here's the command that I used :

cd themes
rm -rf hummingbird
git clone https://github.com/PrestaShop/hummingbird.git hummingbird
cd hummingbird
git prc origin 550 dev
cd _dev && npm i && npm run build

The PR is well installed, the theme is well installed. But when I try to apply it to my shop, I'm having an error.

Screen.Recording.2023-10-13.at.16.31.28.mov

@leemyongpakvn
Copy link
Contributor

@florine2623

cd _dev && npm i && npm run build

There is no _dev directory in this repo, please follow how-to-build-assets. ;)

Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet ,

Sorry for the delay in the answer .

I tested it. Works as expected. LGTM.

Screen.Recording.2024-01-04.at.11.46.39.mov

In my case, I didn't need to rebuild the entire index. I didn't change anything and worked in both cases.

Thanks!

@nicosomb nicosomb merged commit 6711c8b into PrestaShop:develop Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants