Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: buttons, accessibilites #552

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

pawelkierklo
Copy link
Contributor

Google PageSpeed suggests making elements more accessible for a11y. This boosts the page's score by +10 points.

In this change, we've addressed Google PageSpeed's recommendation to enhance accessibility (a11y) of various page elements. This includes improving the structure and attributes of HTML elements to make the page more accessible to all users.

| BC breaks? no
| Deprecations? no

Tested in PageSpeed, Prestashop 8.1.1 and 8.1.2

Google PageSpeed suggests making elements more accessible for a11y. This boosts the page's score by +10 points.
@pawelkierklo
Copy link
Contributor Author

image

Copy link
Contributor

@nicosomb nicosomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@paulnoelcholot
Copy link

Hello @pawelkierklo,

I tested your PR and it's GOOD for me! 🎉

Thanks!

Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@matthieu-rolland
Copy link
Contributor

thank you @pawelkierklo and @paulnoelcholot 👍

@matthieu-rolland matthieu-rolland merged commit 70c54c1 into PrestaShop:develop Oct 4, 2023
6 checks passed
@leemyongpakvn leemyongpakvn added this to the Beta milestone Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants