-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
productcomments - Make rating mandatory #577
productcomments - Make rating mandatory #577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking not to merge before productcomments PR.
@paulnoelcholot Please recheck PrestaShop/productcomments#197 |
Hi @kpodemski, The PR is now merged, @leemyongpakvn can you apply your last changes on this PR ? Thank you |
@AureRita The last commit in PrestaShop/productcomments#197 stays in module's JS. There is no change needed for theme. |
@kpodemski The productcomments PR is now merged. |
@AureRita We are in need or re-QA |
Thank you for your PR, I tested it and it seems to works as you can see : recording.141.webmTested on develop and 8.1.x Because the PR seems to works as expected, It's QA ✔️ Thank you |
(Don't forget to clone a clean develop branch of hummingbird, as well as clear browser cache, PS cache before testing ;)