-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwriting productListingComments.js with the correct product selector #619
Overwriting productListingComments.js with the correct product selector #619
Conversation
This should be fixed already. Try fresh hummingbird and productcomments module min v.6.0.3 |
The query selector was fixed in PrestaShop/productcomments@51a0320 but the PR is still needed for the theme.yml config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chrisai-dev, I agree with you, theme.yml need an update to properly hook the module 👍 even if the PR name does not address the right issue !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @chrisai-dev ,
Thanks for the PR !
I followed the steps, they seem to work. But when I switch back to Classic theme, the hooks are hooked again.
- Make the Classic theme active and ensure the Product Comments module is active if it's not already.
- Unhook the Product Comments module from the following hooks (BO: Design -> Positions):
displayFooterProduct
displayProductAdditionalInfo
displayProductListReviews
- Change the theme to Hummingbird.
- Check in Design -> Positions if the Product Comments module is correctly hooked into the above hooks. ✅
- Go to Design > Theme & Logo > Use this theme for Classic
- Check in Design -> Positions, Product Comments module is hooked to the following
displayFooterProduct
displayProductAdditionalInfo
displayProductListReviews
It should not ❌
Could you check ?
Thanks!
Hi @florine2623, You mean, when you switch from Hummingbird to Classic, the module productcomments hooks again on What @chrisai-dev has done is reproduce the behavior of Classic, which was correct but missing in Hummingbird. I don't know if this is clear ? Don't hesitate to let me know if it's not. |
Hello @tblivet , Ok, it is clear to me. Thanks for the details ^^ |
Thanks @florine2623 and @chrisai-dev |
View a category that has products with reviewsCheck if theme correctly hook productcomments moduleTo test it, go to a shop where the Classic theme and Hummingbird theme are installed.
displayFooterProduct
displayProductAdditionalInfo
displayProductListReviews