Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue-611 #626

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Fix: issue-611 #626

merged 2 commits into from
Jun 5, 2024

Conversation

tblivet
Copy link
Contributor

@tblivet tblivet commented May 17, 2024

Questions Answers
Description? Fix #611
Type? bug fix
BC breaks? no
Deprecations?
Fixed ticket? Fix #611
Sponsor company @PrestaShopCorp
How to test? You can follow the steps described in the issue

@nicosomb nicosomb removed the request for review from matthieu-rolland May 17, 2024 11:27
nicosomb
nicosomb previously approved these changes May 17, 2024
Hlavtox
Hlavtox previously approved these changes May 20, 2024
ga-devfront
ga-devfront previously approved these changes May 20, 2024
@tblivet tblivet dismissed stale reviews from ga-devfront, Hlavtox, and nicosomb via 1950578 May 20, 2024 16:19
@tblivet tblivet requested review from nicosomb and Hlavtox May 20, 2024 16:19
@tblivet
Copy link
Contributor Author

tblivet commented May 20, 2024

Hi, I noticed that there were two blocks intended to display the link, one for Desktop and one for Mobile, so I've updated the PR.

@tblivet tblivet requested a review from ga-devfront May 20, 2024 16:35
@florine2623 florine2623 self-assigned this Jun 5, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet ,

Works as expected :
Screenshot 2024-06-05 at 11 21 34

It's QA ✅
Thanks!

@nicosomb nicosomb added this to the v0.2.1 milestone Jun 5, 2024
@nicosomb nicosomb merged commit 15d13c0 into PrestaShop:develop Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

In Order details page - If my product has a downloadable file, I can't download it
7 participants