-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: issue-340 #627
Fix: issue-340 #627
Conversation
Enhance product list display for various layouts and introduce breakpoints for improved mobile display.
Enhanced pagination and added mobile optimizations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep one column for mobile. In the issue, it was just a suggestion from the author.
Hi @Hlavtox, I don't really understand, you want me to remove one column for mobile? |
@tblivet Ah sorry, too early in the morning. :-) I meant to keep two columns on mobiles, unless on VERY small screen sizes. We can fit more data without as much scrolling. |
@Hlavtox, I think removing it is not a good idea because with 2 products per line on very small devices, we really lose in terms of visibility. As you say, we can fit more data, but we display more data in a bad way. I think it's a good compromise. What do you think? |
@tblivet Yeah! Good solution. :-) Do you want to move the breakpoint or add another one? |
@Hlavtox, Perfect 👍 No, just move it because it's already a new breakpoint! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tblivet ,
Thanks for the PR.
When I try on desktop screen, the 3 dots button doesn't work :
Screen.Recording.2024-06-06.at.11.46.12.mov
On mobile 320px size, the pagination design is as expected.
But it doesn't work so well. The 3-dots button doesn't always work.
Screen.Recording.2024-06-06.at.11.47.44.mov
Although this is not blocking, before this PR, it was already like this. It can be fixed later.
The products are well displayed on mobile size.
It is QA ✅
Thank you, @florine2623 🙏 |
Most of the points described in the issue have already been addressed. The remaining ones have been tackled as follows: