Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: handle scroll offset on anchor links #641

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Feat: handle scroll offset on anchor links #641

merged 1 commit into from
Jun 26, 2024

Conversation

tblivet
Copy link
Contributor

@tblivet tblivet commented Jun 17, 2024

Questions Answers
Description? Add functionality to handle the offset of a sticky header when clicking on anchor links and prevent item overlapping.
Type? new feature
BC breaks? no
Deprecations?
Fixed ticket?
Sponsor company @PrestaShopCorp
How to test? This feature is related to an issue find in this PR #640 (review) (BUG 1)

Before:

scroll_before.mov

After:

scroll_after.mov

@tblivet tblivet requested review from nicosomb, Hlavtox and boherm June 17, 2024 12:35
@florine2623 florine2623 self-assigned this Jun 26, 2024
florine2623
florine2623 approved these changes Jun 26, 2024
View reviewed changes
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it is QA ✅

Screen.Recording.2024-06-26.at.11.43.26.mov

@tblivet tblivet merged commit 3491039 into PrestaShop:develop Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florine2623 florine2623 florine2623 approved these changes

@nicosomb nicosomb nicosomb approved these changes

@Hlavtox Hlavtox Awaiting requested review from Hlavtox

@boherm boherm Awaiting requested review from boherm

Assignees

@florine2623 florine2623

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tblivet @nicosomb @florine2623 @ps-jarvis