chore(deps): upgrade some packages (test for node 20) #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mattgoud! This is your first pull request on hummingbird repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
5 tasks
…ate node version for CI, downgrade typescript version (for eslint compatibility)
jolelievre
reviewed
Sep 30, 2024
| @@ -165,6 +165,7 @@ const usePasswordPolicy = (selector: string): PasswordPolicyReturn => { | |||
| try { | |||
| return JSON.parse(content); | |||
| } catch (error) { | |||
| console.error(error); | |||
boherm
previously approved these changes
Sep 30, 2024
…e console.log(error)
jolelievre
approved these changes
Sep 30, 2024
|
No need functional testing :) ok to be merged |
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
|
Thanks @mattgoud |
|
Just for information, this PR has broken the Storybook setup. But any way it seems it has never been used for years? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade node modules
Upgrade some packages + audit fix (reduce some security warnings) to prepare for the transition to node 20
(see #37041 )