Fix issue #664 #665
Merged
Fix issue #664 #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marsaldev
commented
Dec 2, 2024
•
marsaldev
commented
| Questions | Answers |
|---|---|
| Description? | Center horizontally header icons on mobile view |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes 664 |
| Sponsor company | Myself |
| How to test? | Upload a logo with an height greater than the default one, even a square logo could be fine, navigate with mobile view in the browser |
kpodemski
approved these changes
Dec 2, 2024
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.