fix(build): env path fix for Node.js

PrestaShop · Dec 8, 2023 · 68b186f · 68b186f
1 parent ce4b34f
commit 68b186f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/docker/alpine.Dockerfile b/docker/alpine.Dockerfile
@@ -67,18 +67,19 @@ RUN PHP_CS_FIXER=$(jq -r '."'"${PHP_VERSION}"'".php_cs_fixer' < /tmp/php-flavour
   && chmod a+x /usr/bin/php-cs-fixer
 
 # Install Node.js and pnpm (yarn and npm are included)
+ENV PATH "$PATH:/usr/local/lib/nodejs/bin"
 RUN if [ "0.0.0" = "$NODE_VERSION" ]; then exit 0; fi \
   && apk --no-cache add -U gcompat \
   && if [ "linux/arm64" = "$TARGET_PLATFORM" ]; \
   then export DISTRO="linux-arm64"; \
   else export DISTRO="linux-x64"; \
   fi \
-  && curl --silent --show-error --fail --location --output /tmp/node.tar.xz "https://nodejs.org/dist/v${NODE_VERSION}/node-v${NODE_VERSION}-${DISTRO}.tar.xz" \
+  && curl --silent --show-error --fail --location --output /tmp/node.tar.xz \
+  "https://nodejs.org/dist/v${NODE_VERSION}/node-v${NODE_VERSION}-${DISTRO}.tar.xz" \
   && mkdir -p /tmp/nodejs && tar -xJf /tmp/node.tar.xz -C /tmp/nodejs \
   && mv "/tmp/nodejs/node-v${NODE_VERSION}-${DISTRO}" /usr/local/lib/nodejs \
   && rm -rf /tmp/nodejs /tmp/node.tar.xz \
-  && PATH="$PATH:/usr/local/lib/nodejs/bin" npm install -g yarn@latest pnpm@latest --force
-ENV PATH "$PATH:/usr/local/lib/nodejs/bin"
+  && npm install -g yarn@latest pnpm@latest --force
 
 # --------------------------------
 # Flashlight install and dump SQL

diff --git a/docker/debian.Dockerfile b/docker/debian.Dockerfile
@@ -80,17 +80,18 @@ RUN PHP_CS_FIXER=$(jq -r '."'"${PHP_VERSION}"'".php_cs_fixer' < /tmp/php-flavour
   && chmod a+x /usr/bin/php-cs-fixer
 
 # Install Node.js and pnpm (yarn and npm are included)
+ENV PATH "$PATH:/usr/local/lib/nodejs/bin"
 RUN if [ "0.0.0" = "$NODE_VERSION" ]; then exit 0; fi \
   && if [ "linux/arm64" = "$TARGET_PLATFORM" ]; \
   then export DISTRO="linux-arm64"; \
   else export DISTRO="linux-x64"; \
   fi \
-  && curl --silent --show-error --fail --location --output /tmp/node.tar.xz "https://nodejs.org/dist/v${NODE_VERSION}/node-v${NODE_VERSION}-${DISTRO}.tar.xz" \
+  && curl --silent --show-error --fail --location --output /tmp/node.tar.xz \
+  "https://nodejs.org/dist/v${NODE_VERSION}/node-v${NODE_VERSION}-${DISTRO}.tar.xz" \
   && mkdir -p /tmp/nodejs && tar -xJf /tmp/node.tar.xz -C /tmp/nodejs \
   && mv "/tmp/nodejs/node-v${NODE_VERSION}-${DISTRO}" /usr/local/lib/nodejs \
   && rm -rf /tmp/nodejs /tmp/node.tar.xz \
-  && PATH="$PATH:/usr/local/lib/nodejs/bin" npm install -g yarn@latest pnpm@latest --force
-ENV PATH "$PATH:/usr/local/lib/nodejs/bin"
+  && npm install -g yarn@latest pnpm@latest --force
 
 # --------------------------------
 # Flashlight install and dump SQL