Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fea(run): bin/console polyfill for PS 1.6 to auto-install modules #116

Merged
merged 14 commits into from
Aug 16, 2024
Merged

fea(run): bin/console polyfill for PS 1.6 to auto-install modules #116

merged 14 commits into from
Aug 16, 2024

Conversation

jokesterfr
Copy link
Contributor

@jokesterfr jokesterfr commented Jun 27, 2024 •
edited
Loading

Questions Answers
Description? This PR aims at polyfilling a very interesting feature introduced in PS 1.7: the bin/console. This helps to quickly install any module, regardless of the PrestaShop version you are running in your tests.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #22
Sponsor company PrestaShop, ps_accounts, ps_eventbus.
How to test? php -d memory_limit=-1 bin/console prestashop:module --no-interaction install "ps_accounts"

@jokesterfr jokesterfr self-assigned this Jun 27, 2024
@jokesterfr jokesterfr changed the title Attempt to polyfill the 1.7+ console fea(run): bin/console polyfill for PS 1.6 to auto-install modules Jun 27, 2024
fox-john
fox-john approved these changes Jul 19, 2024
View reviewed changes
assets/patch.sh Outdated Show resolved Hide resolved
assets/patch.sh Outdated Show resolved Hide resolved
release.sh Show resolved Hide resolved
@jokesterfr jokesterfr added the ready to review Looking for a pair review label Aug 16, 2024
@jokesterfr
Copy link
Contributor Author

jokesterfr commented Aug 16, 2024 •
edited
Loading

  • Cache cleaning support by the CLI polyfill

@jokesterfr jokesterfr merged commit 1745eee into main Aug 16, 2024
17 checks passed
@jokesterfr jokesterfr deleted the fea/add-console-to-16 branch August 16, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidPrestashop davidPrestashop davidPrestashop approved these changes

@fox-john fox-john fox-john approved these changes

Assignees

@jokesterfr jokesterfr

Labels
ready to review Looking for a pair review
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PrestaShop 1.6 does not support the console: no module auto-install can be performed yet
3 participants
@jokesterfr @fox-john @davidPrestashop