Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fea(release.sh): automates compatible & recommended php versions #70

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

jokesterfr
Copy link
Contributor

@jokesterfr jokesterfr commented Feb 1, 2024

Questions Answers
Description? Automates the automated build process: now guess all the tags and image combination we wish to build every time flashlight is updated. Also build images for major.minor versions of PrestaShop from 7 to 8+, and major.minor.patch for 1.6. Build images with recommended AND compatible versions of PHP.
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #60
How to test? ./release.sh

@jokesterfr jokesterfr changed the title Release.sh automates recommended php version build fea(release.sh): automates compatible & recommended php versions Feb 1, 2024
@jokesterfr jokesterfr self-assigned this Feb 1, 2024
Copy link

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's monitor docker hub because I'm afraid we might hit a limit of how many images we can push to a single dockerhub account using the free plan 😅

@jokesterfr jokesterfr merged commit f58d647 into main Feb 2, 2024
10 checks passed
@jokesterfr jokesterfr deleted the fea/recommended-php-version branch February 2, 2024 09:02
@jokesterfr
Copy link
Contributor Author

Limit seems now to be hint by the available images from php docker images. For some old combinations we may have to provide only Debian based image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Recommended PHP versions should also be used to provide Docker images on the dockerhub
2 participants