Skip to content

✨ Adding DependencyBuilder #128

✨ Adding DependencyBuilder

✨ Adding DependencyBuilder #128

Triggered via pull request November 14, 2023 11:16
Status Failure
Total duration 2m 9s
Artifacts

php.yml

on: pull_request
PHP Syntax check 5.6|7.2|7.3|8.0|8.1
31s
PHP Syntax check 5.6|7.2|7.3|8.0|8.1
PHP-CS-Fixer
11s
PHP-CS-Fixer
PHPUnit
1m 58s
PHPUnit
Matrix: PHPStan
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 4 warnings
PHPStan (https://github.com/PrestaShop/PrestaShop/releases/download/1.7.4.4/prestashop_1.7.4.4.zip): src/DependencyBuilder.php#L254
Method Prestashop\ModuleLibMboInstaller\DependencyBuilder::getDependencies() never returns array{} so it can be removed from the return type.
PHPStan (https://github.com/PrestaShop/PrestaShop/releases/download/1.7.4.4/prestashop_1.7.4.4.zip): src/DependencyBuilder.php#L258
Offset 'dependencies' on array{dependencies: array{}} in empty() always exists and is always falsy.
PHPStan (https://github.com/PrestaShop/PrestaShop/releases/download/1.7.4.4/prestashop_1.7.4.4.zip): src/DependencyBuilder.php#L259
Method Prestashop\ModuleLibMboInstaller\DependencyBuilder::getDependencies() should return array{}|array{ps_mbo: array<string, bool|int|string>} but returns array{ps_mbo: array<string, bool|int|string>|null}.
PHPStan (https://github.com/PrestaShop/PrestaShop/releases/download/1.7.4.4/prestashop_1.7.4.4.zip): src/DependencyBuilder.php#L325
Method Prestashop\ModuleLibMboInstaller\DependencyBuilder::getDependenciesSpecification() should return array{dependencies: array{}} but returns array.
PHPStan (https://github.com/PrestaShop/PrestaShop/releases/download/8.0.0/prestashop_8.0.0.zip): src/DependencyBuilder.php#L254
Method Prestashop\ModuleLibMboInstaller\DependencyBuilder::getDependencies() never returns array{} so it can be removed from the return type.
PHPStan (https://github.com/PrestaShop/PrestaShop/releases/download/8.0.0/prestashop_8.0.0.zip): src/DependencyBuilder.php#L258
Offset 'dependencies' on array{dependencies: array{}} in empty() always exists and is always falsy.
PHPStan (https://github.com/PrestaShop/PrestaShop/releases/download/8.0.0/prestashop_8.0.0.zip): src/DependencyBuilder.php#L259
Method Prestashop\ModuleLibMboInstaller\DependencyBuilder::getDependencies() should return array{}|array{ps_mbo: array<string, bool|int|string>} but returns array{ps_mbo: array<string, bool|int|string>|null}.
PHPStan (https://github.com/PrestaShop/PrestaShop/releases/download/8.0.0/prestashop_8.0.0.zip): src/DependencyBuilder.php#L325
Method Prestashop\ModuleLibMboInstaller\DependencyBuilder::getDependenciesSpecification() should return array{dependencies: array{}} but returns array.
PHP-CS-Fixer
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHPStan (https://github.com/PrestaShop/PrestaShop/releases/download/1.7.4.4/prestashop_1.7.4.4.zip)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHPStan (https://github.com/PrestaShop/PrestaShop/releases/download/8.0.0/prestashop_8.0.0.zip)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP Syntax check 5.6|7.2|7.3|8.0|8.1
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/