fix: carrier details and taxes #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fox-john
commented
Nov 14, 2024
•
fox-john
commented
- Rework of the shops content carrier-details and carrier-taxes to align with changes introduced in V4 (full sql query)
- Removal of repositories that became obsolete (stateRepository and countryRepository)
- A few additional minor refactors
- Update fixtures
guillaume60240
approved these changes
Nov 19, 2024
| "price": 0 | ||
| "delimiter1": 0, | ||
| "delimiter2": 50, | ||
| "country_ids": "US", |
There was a problem hiding this comment.
On peut pas en avoir avec plusieurs country_ids?
There was a problem hiding this comment.
Bien vu, j'ai peut être un problème ici en effet. J'avais tiqué sur la clé, mais j'avais pas trouvé de notion de plural ici. Je vais corriger ça.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.