feat: [divider] - remove id prop

PrestaShopCorp · Oct 23, 2023 · 90198bf · 90198bf
1 parent 10c2f3a
commit 90198bf
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 15 deletions.
diff --git a/packages/components/divider/src/divider.ts b/packages/components/divider/src/divider.ts
@@ -2,13 +2,7 @@ import { buildProps } from '@puik/utils'
 import type { ExtractPropTypes } from 'vue'
 import type Divider from './divider.vue'
 
-export const dividerProps = buildProps({
-  id: {
-    type: String,
-    required: false,
-    default: undefined,
-  },
-} as const)
+export const dividerProps = buildProps({} as const)
 
 export type DividerProps = ExtractPropTypes<typeof dividerProps>
 

diff --git a/packages/components/divider/src/divider.vue b/packages/components/divider/src/divider.vue
@@ -1,12 +1,10 @@
 <template>
-  <hr :id="id" class="puik-divider" />
+  <hr class="puik-divider" />
 </template>
 
 <script setup lang="ts">
 import { dividerProps } from './divider'
 defineOptions({
   name: 'PuikDivider',
 })
-
-const props = defineProps(dividerProps)
 </script>
diff --git a/packages/components/divider/test/divider.spec.ts b/packages/components/divider/test/divider.spec.ts
@@ -21,9 +21,4 @@ describe('Divider tests', () => {
     factory()
     expect(wrapper).toBeTruthy()
   })
-
-  it('as id prop value is "puik-chip-example", id html attribute of puik-chip should be "puik-chip-example"', () => {
-    factory({ id: 'puik-divider-id' })
-    expect(findDivider().attributes().id).toBe('puik-divider-id')
-  })
 })