Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] puik link decoration underline is fucked up on multi-line 😭 + width 100% not good #232

Closed
MikeLebeau opened this issue Oct 23, 2023 · 2 comments · Fixed by #233
Closed

[BUG] puik link decoration underline is fucked up on multi-line 😭 + width 100% not good #232

MikeLebeau opened this issue Oct 23, 2023 · 2 comments · Fixed by #233
Assignees
@mattgoud
Labels
bug Something isn't working

Comments

@MikeLebeau
Copy link

MikeLebeau commented Oct 23, 2023 •
edited
Loading

Context

Le 'underline' ne s'affiche pas si le texte est sur plusieurs ligne + la width a 100% pose probleme si j'ai un lien dans un flex-col par exemple, jte mets un ptit screen plus bas

  • Browser: Chrome
  • Vue version: 3.3.4
  • Package version: 1.6.1
  • Node version: 20.1
  • NPM Version: 9.6.4
  • PNPM Version: 8.6.3
  • Configuration used: 🤔

Dans ce screen on voit que les liens sur une seule ligne sont nickel mais le lien Prestashop integration documentation. a la fin du petit paragraphe de description n'a pas de 'underline'

image

Soucis de width
image

Reproduce link

Steps to Reproduce

Expected Behavior

Current Behavior

Additional comments
@MikeLebeau MikeLebeau added the bug Something isn't working label Oct 23, 2023
@mattgoud
Copy link
Collaborator

mattgoud commented Oct 23, 2023 •
edited
Loading

ah ! ok je vais regarder @MikeLebeau , peut-être un nowrap pour les links afin d'éviter ce souci.

@mattgoud mattgoud self-assigned this Oct 23, 2023
@MikeLebeau MikeLebeau changed the title [BUG] puik link decoration underline is fucked up on multi-line 😭 [BUG] puik link decoration underline is fucked up on multi-line 😭 + width 100% not good Oct 23, 2023
mattgoud added a commit that referenced this issue Oct 23, 2023
@mattgoud
fix: #232 : puik-link underline on multi-lines
63b895d
@mattgoud mattgoud mentioned this issue Oct 23, 2023
Merged
9 tasks
@mattgoud mattgoud linked a pull request Oct 23, 2023 that will close this issue
fix: #232 : puik-link underline on multi-lines #233
Merged
9 tasks
@mattgoud
Copy link
Collaborator

mattgoud commented Oct 24, 2023 •
edited
Loading

ah ! ok je vais regarder @MikeLebeau , peut-être un nowrap pour les links afin d'éviter ce souci.

@MikeLebeau en fait le nowrap était une mauvaise idée, j'ai utilisé un background image dans la PR pour créer l'underline. ça permet de garder la possibilité de revenir à la ligne.

MikeLebeau pushed a commit that referenced this issue Oct 26, 2023
@mattgoud
fix: #232 : puik-link underline on multi-lines
6aafc1b
MikeLebeau pushed a commit that referenced this issue Oct 30, 2023
Merge pull request #233 from PrestaShopCorp/bug/puik-link-no-underlin…
510f55d 
…e-on-multi-line-and-full-width-not-correct

fix: #232 : puik-link underline on multi-lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattgoud mattgoud

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #232 : puik-link underline on multi-lines PrestaShopCorp/puik
2 participants
@MikeLebeau @mattgoud