Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #232 : puik-link underline on multi-lines #233

Merged
merged 6 commits into from
Oct 30, 2023
Merged

fix: #232 : puik-link underline on multi-lines #233

merged 6 commits into from
Oct 30, 2023

Conversation

mattgoud
Copy link
Collaborator

❓ Types of changes

fix : [BUG] puik link decoration underline is fucked up on multi-line 😭 + width 100% not good #232

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud added the bug Something isn't working label Oct 23, 2023
@mattgoud mattgoud requested a review from MikeLebeau October 23, 2023 15:12
@mattgoud mattgoud self-assigned this Oct 23, 2023
@mattgoud mattgoud linked an issue Oct 23, 2023 that may be closed by this pull request
[BUG] puik link decoration underline is fucked up on multi-line 😭 + width 100% not good #232
Closed
MikeLebeau
MikeLebeau suggested changes Oct 24, 2023
View reviewed changes
packages/theme/src/link.scss Outdated Show resolved Hide resolved
packages/theme/src/link.scss Outdated Show resolved Hide resolved
MikeLebeau
MikeLebeau previously approved these changes Oct 24, 2023
View reviewed changes
Copy link

@MikeLebeau MikeLebeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MikeLebeau MikeLebeau force-pushed the bug/puik-link-no-underline-on-multi-line-and-full-width-not-correct branch 2 times, most recently from 6e25367 to e28b4bd Compare October 27, 2023 12:47
@MikeLebeau MikeLebeau force-pushed the bug/puik-link-no-underline-on-multi-line-and-full-width-not-correct branch from e28b4bd to ab28f69 Compare October 30, 2023 13:19
@MikeLebeau MikeLebeau merged commit 510f55d into main Oct 30, 2023
2 checks passed
@MikeLebeau MikeLebeau deleted the bug/puik-link-no-underline-on-multi-line-and-full-width-not-correct branch October 30, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kktos kktos kktos approved these changes

@cnavarro-prestashop cnavarro-prestashop cnavarro-prestashop left review comments

@MikeLebeau MikeLebeau MikeLebeau left review comments

Assignees

@mattgoud mattgoud

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] puik link decoration underline is fucked up on multi-line 😭 + width 100% not good
4 participants
@mattgoud @kktos @MikeLebeau @cnavarro-prestashop