Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/custom elements for core integration #207

Closed
wants to merge 11 commits into from

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Oct 4, 2023

  • Creation or refactoring of 5 web-components (IconCe, TooltipCe, ButtonCe, ButtonGroupCe, InputCe)
  • Config web-component : define two SFC files (.vue ext for vue component and .ce.vue ext for web-component), define customElement in Puik package (not in playground vue app).
  • Refactoring of input.ce.vue (add hasSlot[named] attributes, handle internal input event, refactoring increase and decrease functions when input type is number)
  • For IconCe, TooltipCe, ButtonCe, ButtonGroupCe : ".ce.vue" files are just copies of the respective ".vue" files

❓ Types of changes

Creation or refactoring of 5 web-components (IconCe, TooltipCe, ButtonCe, ButtonGroupCe, InputCe)

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud added the Feature Type: New Feature label Oct 4, 2023
@mattgoud mattgoud self-assigned this Oct 4, 2023
@mattgoud mattgoud added the WIP Status: Work In Progress label Oct 24, 2023
@mattgoud
Copy link
Collaborator Author

outdated

@mattgoud mattgoud closed this Jan 10, 2024
@mattgoud mattgoud deleted the feat/custom-elements-for-core-integration branch January 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Type: New Feature WIP Status: Work In Progress
Projects
None yet
1 participant