Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/custom elements not defined #222

Closed
wants to merge 19 commits into from
Closed

Conversation

mattgoud
Copy link
Collaborator

  • Don't define web components from puik (remove customElements.define method)
  • additionnal : merge branch "custom-elements-for-core-integration" (no more .ce.vue files)

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud added the bug Something isn't working label Oct 12, 2023
@mattgoud mattgoud requested a review from aAmorim27 October 12, 2023 10:06
@mattgoud mattgoud self-assigned this Oct 12, 2023
@mattgoud mattgoud requested a review from MikeLebeau October 12, 2023 10:06
@mattgoud mattgoud added the WIP Status: Work In Progress label Oct 12, 2023
@mattgoud
Copy link
Collaborator Author

outdated

@mattgoud mattgoud closed this Jan 10, 2024
@mattgoud mattgoud deleted the fix/customElements-not-defined branch January 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WIP Status: Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant