Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some issues with select component #234

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

MikeLebeau
Copy link

@MikeLebeau MikeLebeau commented Oct 26, 2023

Update select component
That Issue + remove rounded corner (options) + options width + put text options on left

❓ Types of changes

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@MikeLebeau MikeLebeau changed the title WIP fix: fix some issues with select component fix: fix some issues with select component Oct 26, 2023
@MikeLebeau MikeLebeau merged commit bc402b9 into main Oct 30, 2023
2 checks passed
@MikeLebeau MikeLebeau deleted the fix_some_shit branch October 30, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants