Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data-test attribute #235

Merged
merged 17 commits into from
Nov 12, 2023
Merged

feat: add data-test attribute #235

merged 17 commits into from
Nov 12, 2023

Conversation

guillaume60240
Copy link
Collaborator

@guillaume60240 guillaume60240 commented Oct 27, 2023

❓ Types of changes

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add props on component to be able to select the data-test attribute for the e2e tests

  • accordion
  • accordion-group => skipped
  • alert
  • badge
  • breadcrumb
  • button
  • button-group => skipped
  • card => skipped
  • checkbox
  • chip => need some help
  • icon
  • input
  • label
  • link
  • menu-item-title
  • modal
  • pagination
  • progress-bar
  • progress-stepper => skipped
  • progress-stepper-step
  • radio
  • select
  • sidebar => skipped
  • sidebar-group
  • sidebar-item
  • sidebar-title
  • skeleton-loader
  • snackbar
  • spinner-loader
  • switch
  • tab-navigation
  • table
  • tag
  • textarea
  • tooltip

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@guillaume60240 guillaume60240 added the WIP Status: Work In Progress label Oct 27, 2023
@guillaume60240 guillaume60240 self-assigned this Oct 27, 2023
fox-john
fox-john previously approved these changes Oct 30, 2023
@guillaume60240 guillaume60240 removed the WIP Status: Work In Progress label Nov 2, 2023
@mattgoud mattgoud merged commit 3e7a85e into main Nov 12, 2023
3 of 5 checks passed
@mattgoud mattgoud deleted the EB-1111-data-test branch November 12, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants