Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat - Add close button to alert component #236

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Feat - Add close button to alert component #236

merged 5 commits into from
Oct 31, 2023

Conversation

aAmorim27
Copy link
Contributor

@aAmorim27 aAmorim27 commented Oct 30, 2023 •
edited by ClaraLpresta
Loading

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added a close button to the Alert component

⚠️ We need this feature before the end of this sprint

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

kktos
kktos suggested changes Oct 30, 2023
View reviewed changes
packages/components/alert/src/alert.ts Outdated Show resolved Hide resolved
MikeLebeau
MikeLebeau previously approved these changes Oct 30, 2023
View reviewed changes
Copy link

@MikeLebeau MikeLebeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas testé en local mais ok pour moi \o/

@aAmorim27 aAmorim27 requested a review from kktos October 30, 2023 16:31
@aAmorim27 aAmorim27 merged commit 6149ec7 into main Oct 31, 2023
2 checks passed
@aAmorim27 aAmorim27 deleted the feat/add-close-button-to-alert branch October 31, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeLebeau MikeLebeau MikeLebeau approved these changes

@kktos kktos kktos approved these changes

@cnavarro-prestashop cnavarro-prestashop cnavarro-prestashop left review comments

@mattgoud mattgoud Awaiting requested review from mattgoud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aAmorim27 @kktos @MikeLebeau @cnavarro-prestashop